Integrate pynxtools igor #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettigl
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Generally looks good to me, however I am wondering why no tests are failing, as there is no release of pynxtools-igor yet. Maybe we should include such a test (i.e. which installs pynxtools[convert])
The strategy for merging should be:
- Merge this
- Make a new pynxtools release (with allow the use of wildcard definitions for the reader tests #476)
- Fix requirements in pynxtools-igor to the new version
- Make first pynxtools-igor release
|
Yes, we don't actually test which plugins are installable or installed. We can make a test for that (see #482). The plugin tests are anyway run from the github repos though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.